Remove references to key lifetime #2
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ionut-arm
reviewed
Oct 22, 2019
| } | ||
|
|
||
| message KeyAttributesProto { | ||
| KeyLifetime key_lifetime = 1; |
There was a problem hiding this comment.
Can you pull the tag numbers down to start from 1 again?
ionut-arm
reviewed
Oct 22, 2019
|
|
||
| message OpAsymmetricVerifyProto { | ||
| string key_name = 1; | ||
| key_attributes.KeyLifetime key_lifetime = 2; |
There was a problem hiding this comment.
Same, tags should be in order
ionut-arm
reviewed
Oct 22, 2019
|
|
||
| message OpAsymmetricSignProto { | ||
| string key_name = 1; | ||
| key_attributes.KeyLifetime key_lifetime = 2; |
|
Oops, forgot about that, will change! |
hug-dev
force-pushed
the
remove-lifetimes
branch
from
7235269 to
12076fd
Compare
ionut-arm
approved these changes
Oct 22, 2019
This change makes the operations simpler by removing the KeyLifetime attribute of the keys. The choice between using permanent or volatile keys is now going to be done at the provider level with providers using either volatile or permanent keys. Signed-off-by: Hugues de Valon <[email protected]>
hug-dev
force-pushed
the
remove-lifetimes
branch
from
12076fd to
caeb47c
Compare
|
Updated the changes to keep the same field numbers but use |
hug-dev
added a commit
to hug-dev/parsec-interface-rs
that referenced
this pull request
Oct 22, 2019
Removes all key lifetime after parallaxsecond/parsec-operations#2. Signed-off-by: Hugues de Valon <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change makes the operations simpler by removing the KeyLifetime
attribute of the keys.
The choice between using permanent or volatile keys is now going to be
done at the provider level with providers using either volatile or
permanent keys.
Signed-off-by: Hugues de Valon [email protected]